Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ubuntu 22.04 support #445

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Add Ubuntu 22.04 support #445

merged 1 commit into from
Aug 6, 2024

Conversation

bastelfreak
Copy link
Collaborator

Summary

Provide a detailed description of all the changes present in this pull request.

Additional Context

Add any additional context about the problem here.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.

Changes include test coverage?

  • Yes
  • Not needed

Have you updated the documentation?

  • Yes, I've updated the appropriate docs
  • Not needed

@bastelfreak bastelfreak self-assigned this Jun 24, 2024
@bastelfreak bastelfreak requested review from a team as code owners June 24, 2024 16:17
@Jo-Lillie
Copy link
Contributor

Hi @bastelfreak can you please rebase this against main

@bastelfreak
Copy link
Collaborator Author

It probably makes sense to add Ubuntu to some of the test platforms in .github/workflows. But there are so many files, I'm not sure which one is desired.

@cathal41
Copy link
Contributor

cathal41 commented Jul 3, 2024

Ubuntu 22.04 will need to be added to the puppet litmus repo as this is where we provision our environments https://github.com/puppetlabs/puppet_litmus/blob/main/exe/matrix_from_metadata_v2

@cathal41 cathal41 mentioned this pull request Jul 3, 2024
6 tasks
@CoMfUcIoS
Copy link
Contributor

@bastelfreak please rebase. Puppet litmus added those images so we can now test Ubuntu 22.04 in our CI! It should be picked up automatically from metadata.json

@CoMfUcIoS CoMfUcIoS marked this pull request as draft August 5, 2024 19:45
@CoMfUcIoS CoMfUcIoS marked this pull request as ready for review August 5, 2024 19:45
@CoMfUcIoS CoMfUcIoS merged commit c61e503 into main Aug 6, 2024
55 checks passed
@CoMfUcIoS CoMfUcIoS deleted the ubuntu2 branch August 6, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants